Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest JDK distribution by AdoptOpenJDK #119

Merged
merged 4 commits into from
Apr 1, 2019
Merged

Suggest JDK distribution by AdoptOpenJDK #119

merged 4 commits into from
Apr 1, 2019

Conversation

akaroml
Copy link
Member

@akaroml akaroml commented Mar 29, 2019

This is to provide more JDK options for users to choose.
OS and architecture are automatically detected.

Screen Shot 2019-03-29 at 10 18 03 PM

Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Workflow looks ok. But with some nits in TS files, single quotes are still used, looks it hasn't been guarded well.

src/overview/assets/index.ts Outdated Show resolved Hide resolved
src/overview/assets/index.ts Show resolved Hide resolved
src/overview/assets/index.ts Outdated Show resolved Hide resolved
src/java-runtime/index.ts Show resolved Hide resolved
src/java-runtime/index.ts Outdated Show resolved Hide resolved
src/overview/assets/index.html Outdated Show resolved Hide resolved
src/overview/assets/index.html Show resolved Hide resolved
src/java-runtime/index.ts Outdated Show resolved Hide resolved
@akaroml
Copy link
Member Author

akaroml commented Mar 31, 2019

Workflow looks ok. But with some nits in TS files, single quotes are still used, looks it hasn't been guarded well.

Single quote now only appears in webpack.config.js, which is out of the scope of ts.

@akaroml akaroml merged commit 375b883 into master Apr 1, 2019
@akaroml akaroml deleted the suggest-jdk branch April 1, 2019 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants