Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc for Microsoft Graph migration #2985

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Feb 24, 2022

Add doc for Microsoft Graph migration.

@opbld30
Copy link

opbld30 commented Feb 24, 2022

Docs Build status updates of commit 1d5a40c:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/microsoft-graph-migration.md 💡Suggestion View Details
docs-ref-conceptual/TOC.yml ✅Succeeded View

docs-ref-conceptual/microsoft-graph-migration.md

  • Line 17, Column 8: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/graph/migrate-azure-ad-graph-overview' will be broken in isolated environments. Replace with a relative link.
  • Line 21, Column 89: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/graph/migrate-azure-ad-graph-property-differences' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld32
Copy link

opbld32 commented Feb 24, 2022

Docs Build status updates of commit 5775818:

✅ Validation status: passed

File Status Preview URL Details
docs-ref-conceptual/TOC.yml ✅Succeeded View
docs-ref-conceptual/microsoft-graph-migration.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

Copy link
Collaborator

@dbradish-microsoft dbradish-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiasli , @chasewilson , I feel we need some "before" and "after" actual examples in this article. I will definitely need this as well as this change impacts the following:

az ad app create -- 18 articles
az ad app permission grant -- 3 articles
az ad app credential reset -- no articles
az ad sp delete -- 5 articles
etc.

Maybe use tabbed conceptual with the new method on the top tab /or/ use dependent tabs?

---
These commands can also be used to reactivate your virtual environment.

1. Install Azure CLI beta
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jiasli, this information used to be in our install docs, so two questions: 1.) what was the thought process behind removing information about Beta from our install docs, and 2.) is this the best (only) place for Beta information?

Copy link
Member Author

@jiasli jiasli Feb 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly. The beta installation guide was removed by #2807 after the MSAL migration.

We don't have regular beta releases. In other words, beta is only for specific features like MSAL, Microsoft Graph. We stop releasing beta versions after jobs are finished.

@jiasli
Copy link
Member Author

jiasli commented Mar 1, 2022

@dbradish-microsoft, this is only the first version. Let's refine it later. 😉 We need to catch up with tomorrow's beta release.


```bash
python -m pip install --upgrade pip
pip install --extra-index-url https://azcliprod.blob.core.windows.net/beta/simple/ azure-cli
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install --extra-index-url https://azcliprod.blob.core.windows.net/beta/simple/ azure-cli
pip install --extra-index-url https://azcliprod.blob.core.windows.net/beta/simple/azure-cli

I don't think there is supposed to be a space here? Correct me if I'm wrong. it will install but with a warning and adjusted url:

warning: missing-index-doctype

× The package index page being used does not have a proper HTML doctype declaration.
╰─> Problematic URL: https://azcliprod.blob.core.windows.net/beta/simple/azure-cli/

Copy link
Member Author

@jiasli jiasli Mar 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the space is required because https://azcliprod.blob.core.windows.net/beta/simple/ is the index URL and azure-cli is the package name.

The page doesn't work because we haven't published beta yet. I will do that today.

@jiasli jiasli merged commit 1795751 into MicrosoftDocs:main Mar 4, 2022
@jiasli jiasli deleted the ms-graph branch March 4, 2022 02:35
@opbld33
Copy link

opbld33 commented Mar 4, 2022

Docs Build status updates of commit 2686fc0:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error: GitBranchDeletedOrForcePushed] Cannot sync git repo to specified commit because branch ms-graph has been deleted or has been force pushed

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@jiasli jiasli mentioned this pull request Mar 4, 2022
@jiasli
Copy link
Member Author

jiasli commented Mar 4, 2022

@chasewilson, your error warning: missing-index-doctype is caused by a recent change of pip: pypa/pip#10825

I have updated the beta release script: https://github.com/jiasli/az-publish/commit/1f1b4745aa9c9e913aa434f45d1c6b777b173a34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants