Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update register-existing-system.md #125733

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ankitaja19
Copy link
Contributor

Added steps to connect to outbound connectivity for windows system

Copy link
Contributor

@ankitaja19 : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 06a501a:

✅ Validation status: passed

File Status Preview URL Details
articles/sap/center-sap-solutions/register-existing-system.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ankitaja19
Copy link
Contributor Author

#sign-off

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @kalyaninamuduri

@@ -42,6 +42,9 @@ When you register a system with Azure Center for SAP solutions, the following re
- Use a [**Service tags**](../../virtual-network/service-tags-overview.md) to allow connectivity
- Use a [Service tags with regional scope](../../virtual-network/service-tags-overview.md) to allow connectivity to resources in the same region as the VMs.
- Allowlist the region-specific IP addresses for Azure Storage, ARM and Microsoft Entra ID.
- For Windows system, ACSS requires outbound connectivity to wwww.microsoft.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add the reason why this connectivity to microsoft.com is needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the reason why we need connectivity to microsoft.com

Copy link
Contributor Author

@ankitaja19 ankitaja19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the reason why we need connectivity to microsoft.com

Copy link
Contributor

Learn Build status updates of commit c0be760:

✅ Validation status: passed

File Status Preview URL Details
articles/sap/center-sap-solutions/register-existing-system.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@ttorble
Copy link
Contributor

ttorble commented Feb 5, 2025

@kalyaninamuduri

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Feb 5, 2025
@@ -42,6 +42,9 @@ When you register a system with Azure Center for SAP solutions, the following re
- Use a [**Service tags**](../../virtual-network/service-tags-overview.md) to allow connectivity
- Use a [Service tags with regional scope](../../virtual-network/service-tags-overview.md) to allow connectivity to resources in the same region as the VMs.
- Allowlist the region-specific IP addresses for Azure Storage, ARM and Microsoft Entra ID.
- For Windows system, ACSS requires outbound connectivity to www.microsoft.com
- ACSS Health and Status script are signed with a certificate whose certificate revocation list URL points to www.microsoft.com therefore for windows system, ACSS requires outbound connectivity to www.microsoft.com
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better clarity to customers, please make the update to the documentation indicating that ACSS runs PowerShell scripts through a VM extension to provide various capabilities. PS scripts are signed by Microsoft. On Windows OS, the script signature is validated and for the validation to be successful the URL must be allow-listed. Otherwise, functionalities in ACSS will not work as expected.

Made the required changes
Copy link
Contributor Author

@ankitaja19 ankitaja19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the requested changes

Copy link
Contributor

Learn Build status updates of commit 5072163:

✅ Validation status: passed

File Status Preview URL Details
articles/sap/center-sap-solutions/register-existing-system.md ✅Succeeded

For more details, please refer to the build report.

For any questions, please:

@v-dirichards
Copy link
Contributor

@kalyaninamuduri Could you review this proposed update to your article and enter #sign-off in a comment if it's ready to merge?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants