Update manually-register-azure-ad-apps.md #4656
Conversation
The server app created should be a web app, not a native/desktop/mobile app.
|
@slbishop : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
|
Learn Build status updates of commit c58ae0b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
Learn Build status updates of commit c58ae0b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
prmerger-automator
bot
added
qualifies-for-auto-merge
and removed
qualifies-for-auto-merge
labels
|
Learn Build status updates of commit 63be92e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
This pull request was approved several weeks ago and has the qualifies-for-auto-merge label, but it hasn't been merged back into the main branch yet so document hasn't been updated. Is there anything else I need to do for the update to get published? |
|
#sign-off |
|
So after #sign-off, the ready-to-merge tag was added weeks ago, but the document still hasn't been updated with this pull request. Is there something else I need to do? Do I need to close the pull request before it actually merges and gets updated? |
|
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @BalaDelli |
|
#sign-off |
|
I have signed off few weeks back and now.
Regards
Balasubramanian Delli (Bala)
Prin Product Manager
#bettertogether
From: prmerger-automator[bot] ***@***.***>
Sent: Friday, December 6, 2024 11:10 PM
To: MicrosoftDocs/memdocs ***@***.***>
Cc: Balasubramanian Delli ***@***.***>; Mention ***@***.***>
Subject: Re: [MicrosoftDocs/memdocs] Update manually-register-azure-ad-apps.md (PR #4656)
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @BalaDelli<https://github.com/BalaDelli>
-
Reply to this email directly, view it on GitHub<#4656 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATTDMJVVBEDXGXOPUDFTNOD2EHONNAVCNFSM6AAAAABQNBSGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRTHAZDMNRTGQ>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
|
If nothing else is required, I'm closing the pull request. Hopefully the pull request will merge into the main branch soon and the update will be published. |
prmerger-automator
bot
added
do-not-merge
and removed
qualifies-for-auto-merge
ready-to-merge
labels
|
Re-opening because after closing, a message showed there were unmerged commits and the branch could be deleted. It seems that a merge won't happen if the pull request is closed before being merged back into the main branch. |
|
Learn Build status updates of commit 63be92e: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
prmerger-automator
bot
added
qualifies-for-auto-merge
and removed
qualifies-for-auto-merge
labels
|
Learn Build status updates of commit c545bf0: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
@BalaDelli my apologies. I thought maybe I needed to close the PR for it to merge back into the main branch, but that didn't seem correct after I did it. So I reopened it and now it's back to having the "qualifies-for-auto-merge" label instead of the "ready-to-merge" label. Do you need to sign off again? Is there anything else I need to do for this PR to merge back into main and get published? It sat in the "ready-to-merge" state for several weeks so I'm unclear if something else is required. When I updated documents in the past as a Microsoft employee, this process went a lot faster, but this is taking a long time now. |
|
Hi Shawn,
Public repo changes are not done by our team, it should go and have a different process.
Regards
Balasubramanian Delli (Bala)
Prin Product Manager
#bettertogether
From: Shawn Bishop ***@***.***>
Sent: Saturday, December 7, 2024 2:15 AM
To: MicrosoftDocs/memdocs ***@***.***>
Cc: Balasubramanian Delli ***@***.***>; Mention ***@***.***>
Subject: Re: [MicrosoftDocs/memdocs] Update manually-register-azure-ad-apps.md (PR #4656)
@BalaDelli<https://github.com/BalaDelli> my apologies. I thought maybe I needed to close the PR for it to merge back into the main branch, but that didn't seem correct after I did it. So I reopened it and now it's back to having the "qualifies-for-auto-merge" label instead of the "ready-to-merge" label. Do you need to sign off again? Is there anything else I need to do for this PR to merge back into main and get published? It sat in the "ready-to-merge" state for several weeks so I'm unclear if something else is required. When I updated documents in the past as a Microsoft employee, this process went a lot faster, but this is taking a long time now.
-
Reply to this email directly, view it on GitHub<#4656 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ATTDMJT3OH55TRPLFONALN32EIEFLAVCNFSM6AAAAABQNBSGJ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMRUGE2DINBQGY>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
|
The server app created should be a web app, not a public client/native app.