Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync master and develop after 2.0 release #979

Merged
merged 35 commits into from
May 27, 2020
Merged

Sync master and develop after 2.0 release #979

merged 35 commits into from
May 27, 2020

Conversation

s-martin
Copy link
Collaborator

No description provided.

s-martin and others added 30 commits January 15, 2020 22:44
Hotfix: Make RFID reader service working again
hotfix: installer shall use master
Use fix from #771 also on master.

Supposed to fix issue #783
Pin mopidy-iris to last version working with python 2
* Make master py3 compatible

* Use py3

* Make py3 compatible

* Make py3 compatible

* Make py3 compatible

* Make py3 compatible

* Make py3 compatible

* Make py3 compatible

* Make py3 compatible

* Make py3 compatible

* Make py3 compatible
* use always python 3 for RegisterDevice.py
Make master py3 compatible
File name on ˋmasterˋ is still with underscores
Hotfix: installation of py packages now for python 3
andreasbrett and others added 5 commits April 5, 2020 19:35
delay shutdown if apt update/upgrade is running
# Conflicts:
#	.github/workflows/pythonpackage.yml
#	misc/sampleconfigs/phoniebox-rotary-encoder.service.stretch-default.sample
#	scripts/MFRC522.py
#	scripts/Reader.py.experimental
#	scripts/Reader.py.kkmoonRFIDreader
#	scripts/daemon_rfid_reader.py
#	scripts/installscripts/buster-install-default.sh
#	scripts/installscripts/stretch-install-default.sh
#	scripts/installscripts/stretch-install-spotify.sh
#	scripts/playout_controls.sh
#	scripts/python-phoniebox/PhonieboxConfigChanger.py
@s-martin s-martin requested a review from MiczFlor May 25, 2020 18:18
Copy link
Collaborator Author

@s-martin s-martin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme has only the actual release date I added yesterday.

The service file has just whitespace changes.

@MiczFlor, could you review also? From my point of view there are no changes back to develop.

@s-martin s-martin changed the title Sync master and develop Sync master and develop after 2.0 release May 25, 2020
@s-martin s-martin mentioned this pull request May 26, 2020
@MiczFlor MiczFlor merged commit e9668be into develop May 27, 2020
@MiczFlor
Copy link
Owner

MiczFlor commented Jun 2, 2020

Hi @s-martin
what would be the best way to go about the syncing of master and develop. Are they synced now? My feeling is that the best way would be ... extreme ...?

  1. delete master
  2. rename develop into master
  3. create new develop from master

But I am not sure if that is necessary at the moment. With this merge you synced master issues back into develop?

@s-martin
Copy link
Collaborator Author

s-martin commented Jun 3, 2020

master is in sync with develop, i.e. develop contains all changes from develop and master.

We can continue working on develop and when the next release is ready we can merge again develop to master. As long as we don't apply any hotfixes to master we don't need to merge master to develop.

I don't think we need to delete and rename the branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants