DEV: Allow Net::HTTP#request patch to be applied with module prepend or method aliasing #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to method aliasing
|
yes, this seems completely reasonable, be sure you update the readme though |
glaszig
added a commit
to glaszig/rack-mini-profiler
that referenced
this pull request
Jun 17, 2020
don't use alias_method since peek-mysql2 uses prepend on rails >= 5 related to MiniProfiler#437 and MiniProfiler#444
glaszig
added a commit
to glaszig/rack-mini-profiler
that referenced
this pull request
Jan 23, 2021
don't use alias_method since peek-mysql2 uses prepend on rails >= 5 related to MiniProfiler#437 and MiniProfiler#444
ivoanjo
added a commit
to DataDog/logging
that referenced
this pull request
Jun 15, 2021
Directly modifying the `Thread` class leads to `stack level too deep (SystemStackError)` if other gems have prepended modules to `Thread`, see for instance: * <rollbar/rollbar-gem#1018> * <MiniProfiler/rack-mini-profiler#444> * <https://github.com/DataDog/dd-trace-rb/blob/master/docs/GettingStarted.md#stack-level-too-deep> This behavior can be triggered with the following example app (NOTE: the issue is triggered only on Linux, as due to unrelated reasons the ddtrace gem only adds the module to `Thread` on that OS): ```ruby require 'bundler/inline' gemfile do source 'http://rubygems.org' gem 'logging', '= 2.3.0', require: false gem 'ddtrace', '= 0.50.0', require: false gem 'google-protobuf' end require 'ddtrace' Datadog.configure do |c| c.profiling.enabled = true end require 'logging' Thread.new { }.join ``` By changing context inheritance to use a `prepend`, it becomes compatible with all libraries that use this technique as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SamSaffron what do you think about this? This will allow people to choose how our Net::HTTP is applied like we allow our Rails patches to be optional. People who want our Net::HTTP patch to be applied using module prepend, they can do something like this in their Gemfile:
Right now people who have other gems with patches that conflict with our patch are forced to either pin their Mini Profiler version and avoid updates, or remove one of the conflicting gems. I think it's nice if we can do something simple to avoid picking sides.