TS Library src #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tifrel
requested changes
Jan 31, 2024
ts-lib/src/encryption/base58.ts
Outdated
|
|
||
| async retrieveAndDecryptKey( | ||
| nearAccount: NearAccount, | ||
| nonce?: string | undefined, |
There was a problem hiding this comment.
Why make this optional here and then use the non-null assertion on it later?
There was a problem hiding this comment.
Some Encryption libraries (like the one introduced here) use a nonce and others don't. This makes it possible to reuse the same interface for both. See #9
tifrel
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We split up the logic from the test into an actual library:
Essentially just performing the same thing the test did before, but offloading all the code logic to the library so the test can be slimmed down.
Closes #1 (introducing the toy/sample encryption library).
Test Plan
Existing CI.