-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build pipeline #126
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mischback
added
area/repository
Affects the repository structure
lang/python
type/improvement
Improvement of an existing feature
labels
Mar 28, 2024
The original implementation idea was: Identify the assets to be busted by having a pattern ([BUSTING]) in their filename (this the method of ``posthtml-hash``). The new approach with a dedicated custom script does not require this artificial setup, so the assets' names were reverted to their original names and the build process (in ``Makefile``) was adjusted.
Mischback
force-pushed
the
feat/build-pipeline
branch
from
April 1, 2024 20:18
9532bb9
to
f1d6d82
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/repository
Affects the repository structure
lang/python
type/improvement
Improvement of an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pre-commit
configuration #125Makefile
:$(STAMP_NODE_READY)
and$(TOX_VENV_INSTALLED)
as order-only prerequisites as neededSTYLE_DIR := $(THEME_DIR)/_src/style
util/lint/prettier
andutil/lint/stylelint
require$(STAMP_NODE_READY)
as (order-only) prerequisite, as they are executed from the localNodeJS
installationecho
statements.build/_static/style.css
). All files in.build
are created/updated when runningSphinx
/ when the recipe for$(STAMP_SPHINX_COMPLETED)
is executed. Is it safe to include an empty target like$(BUILD_DIR)/_static/style.css : $(STAMP_SPHINX_COMPLETED) ;
in theMakefile
to track this dependency?make
's manual explicitly mentions the use case for artifacts, that are generated as side-effects of other recipes/targets, which is the case here (.build/_static/style.css
is a side-effect of runningSphinx
while executing the recipe for$(STAMP_SPHINX_COMPLETED)
).build/genindex/index.html
.build/objects.inv
.build/search/index.html
.build/searchindex.js
.build/_static/pygments.css
.build/_static/style.css.map
.build/
, e.g..doctrees/
and.buildinfo
Sphinx
'slinkcheck
builder is used. Probably it is creating filesoutput.json
andoutput.txt
in the.build/
directoryrm
them!