Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fetch() browser support in docs #2522

Merged
merged 2 commits into from
Aug 30, 2019
Merged

Update fetch() browser support in docs #2522

merged 2 commits into from
Aug 30, 2019

Conversation

qgustavor
Copy link
Contributor

As Can I use shows fetch() supported since Safari 10.1 and iOS Safari 10.3.

Description

Removed Safari from the list of browsers that don't support fetch().

Motivation and Context

This info is outdated.

Other changes to consider (not included in the pull request at the moment):

I don't know: if the first point is still valid or not, as both Fetch and XMLHttpRequest specifications were updated this month. Seems both are subject to specification changes.

The second point seems outdated: it's possible to cancel a request using a AbortController. Browser support is almost the same as fetch().

The third point is still valid: fetch standard still misses upload progress hooks.

About the polyfill size there's this polyfill: 1 kB min, 554 b min+gzip, without AbortController support. According to BundlePhobia, whatwg-fetch is 7.9 kB min and 2.7 kB min+gzip, which raises a question: the "over 11kB" claim is from non-minified code? If so isn't it a bad metric, as it's affected by comments?

Seems the other points, like integration with the autoredrawing subsystem and interpolation, are still valid.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation change

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated docs/change-log.md

docs/request.md Outdated Show resolved Hide resolved
Co-Authored-By: Isiah Meadows <[email protected]>
@dead-claudia dead-claudia merged commit ddb3d4a into MithrilJS:next Aug 30, 2019
@JAForbes JAForbes mentioned this pull request Apr 28, 2022
StephanHoyer pushed a commit that referenced this pull request May 16, 2022
* Update fetch() browser support in docs

As https://caniuse.com/#feat=fetch shows it's supported since Safari 10.1.

* Update docs/request.md

Co-Authored-By: Isiah Meadows <[email protected]>

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants