Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cold users/items support in non-personilized models #120

Merged
merged 18 commits into from
Apr 16, 2024

Conversation

feldlime
Copy link
Collaborator

@feldlime feldlime commented Apr 4, 2024

Description

  • Supported cold recommendations in non-personalized models (random, popular and popular-in-category)
  • Added check for incorrect types of cold targets
  • Changed the logic of choosing random sampler for RandomModel and increased the sampling speed
  • Changed the logic of RandomModel: now the recommendations are different for repeated calls of recommend methods

Closes #119

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

@feldlime feldlime marked this pull request as draft April 4, 2024 08:27
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (ec1bea6).
Report is 40 commits behind head on main.

❗ Current head ec1bea6 differs from pull request most recent head 72d0eef. Consider uploading reports for the commit 72d0eef to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #120    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           45        51     +6     
  Lines         2242      2917   +675     
==========================================
+ Hits          2242      2917   +675     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feldlime feldlime marked this pull request as ready for review April 8, 2024 11:10
@feldlime feldlime requested a review from blondered April 8, 2024 11:10
rectools/models/random.py Outdated Show resolved Hide resolved
rectools/models/random.py Outdated Show resolved Hide resolved
rectools/models/random.py Outdated Show resolved Hide resolved
rectools/models/random.py Outdated Show resolved Hide resolved
@feldlime feldlime merged commit 5c3476d into main Apr 16, 2024
7 checks passed
@feldlime feldlime deleted the feature/cold_for_nonpersonalized_models branch April 16, 2024 09:51
blondered pushed a commit that referenced this pull request Sep 23, 2024
- Supported cold recommendations in non-personalized models (random, popular and popular-in-category)
- Added check for incorrect types of cold targets
- Changed the logic of choosing random sampler for `RandomModel` and increased the sampling speed
- Changed the logic of `RandomModel`: now the recommendations are different for repeated calls of recommend methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cold users/items support for non-personalized models
2 participants