Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/random state to pure svd #130

Merged
merged 20 commits into from
Jun 9, 2024
Merged

Conversation

feldlime
Copy link
Collaborator

@feldlime feldlime commented May 14, 2024

Description

  • Added random_state, maxiter and tol parameters to the PureSVD model
  • Refactored Intersection metric
  • Fixed coverage part in the test workflow
  • Fixed coverage of the code

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Optimization

How Has This Been Tested?

Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.

  • Have you read the contribution guide?
  • Have you updated the relevant docstrings? We're using Numpy format, please double-check yourself
  • Does your change require any new tests?
  • Have you updated the changelog file?

@feldlime feldlime marked this pull request as ready for review June 8, 2024 10:47
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9b3992e) to head (c914cfa).
Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main      #130    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           45        53     +8     
  Lines         2242      3111   +869     
==========================================
+ Hits          2242      3111   +869     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@feldlime feldlime requested a review from blondered June 8, 2024 11:54
@feldlime feldlime merged commit f703287 into main Jun 9, 2024
9 checks passed
@feldlime feldlime deleted the feature/random_state_to_pure_svd branch June 9, 2024 21:55
blondered pushed a commit that referenced this pull request Sep 23, 2024
- Added `random_state`, `maxiter` and `tol` parameters to the PureSVD
model
- Refactored `Intersection` metric
- Fixed `coverage` part in the `test` workflow
- Fixed coverage of the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants