-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LightFM Python 3.12+ support #224
LightFM Python 3.12+ support #224
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 59 +14
Lines 2242 3872 +1630
===========================================
+ Hits 2242 3872 +1630 ☔ View full report in Codecov by Sentry. |
Confirmed the CI passed with Python 3.12 with LightFM https://github.com/MobileTeleSystems/RecTools/actions/runs/12209831381/job/34065165444?pr=224 |
@feldlime JFYI, here is the proof of concept for feldlime/rectools-lightfm#4 |
961400d
to
4e88b95
Compare
3015119
to
e8ffa62
Compare
Since implicit doesn't provide wheels on PyPI for Python 3.12+, CI takes longer than other versions. https://github.com/MobileTeleSystems/RecTools/actions/runs/12225017897/job/34098490713?pr=224 We may want to host some wheels for implicit, like nmslib-metabrainz. |
ffb0fc3
to
d976b71
Compare
d976b71
to
844834e
Compare
@feldlime Now I use rectools-lightfm 1.17.3, and ready for review. Please have a look when you have a chance. |
1b39e05
to
1bb6030
Compare
1bb6030
to
a9e585b
Compare
Thanks @chezou, merging it |
Description
This PR is to support LightFM for Python 3.12+
Bonus
I locally confirmed it works with Python 3.13 with 380b975
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.