Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changed notice migration generation. Added zip file to release. #1736

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

jcpitre
Copy link
Contributor

@jcpitre jcpitre commented Apr 8, 2024

Summary:
Closes #1719

This issue has 2 parts:

  • Include automated Github action of Notice Migration updates when the release is official

The new process is:

  1. Manually run the notice migration GH action (manually specifying the version) -> this adds to the NOTICE_MIGRATION.md file and creates the PR
  2. Merge the PR
  3. Release
  • Upload the .zip installers to the release assets.

Expected behavior:
Follow the new section 2. Update NOTICE_MIGRATION.md file in docs/RELEASE.md.
After running the github action, a new PR should have been created with the notice migration data for the specified release.

For the upload zip installers task , create a fake draft release and verify that the 3 installer zip files are present as release artefacts.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@jcpitre jcpitre linked an issue Apr 8, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Apr 8, 2024

✅ Rule acceptance tests passed.
New Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Errors: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
New Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
Dropped Warnings: 0 out of 1520 datasets (~0%) are invalid due to code change, which is less than the provided threshold of 1%.
0 out of 1520 sources (~0 %) are corrupted.
Commit: dff4685
Download the full acceptance test report here (report will disappear after 90 days).
✅ Rule acceptance tests passed.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidgamez davidgamez merged commit f1705cf into master Apr 9, 2024
280 checks passed
@davidgamez davidgamez deleted the 1719-release-process-improvements-to-be-made branch April 9, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release process improvements to be made
2 participants