feat: 1791 feed infotxt should be added to missing required file when translationstxt exists #1803
Conversation
…hen translations.txt exists
…ng_required_file-when-translationstxt-exists
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 0b24cc9 📊 Notices ComparisonNew Errors (6 out of 1563 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1563 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1563 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (6 out of 1563 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1563 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
core/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsFeedLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsFeedLoader.java
Outdated
Show resolved
Hide resolved
|
Maybe you could add some tests? |
|
I think we can follow an already implemented pattern for the conditionally required files. Example: calendar.txt.
|
core/src/main/java/org/mobilitydata/gtfsvalidator/table/GtfsTableDescriptor.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java
Outdated
Show resolved
Hide resolved
… original loop that processes the files.
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit f3ef039 📊 Notices ComparisonNew Errors (6 out of 1563 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1563 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1563 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (6 out of 1563 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1563 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 3a4dbdc 📊 Notices ComparisonNew Errors (2 out of 1563 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1563 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1563 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (6 out of 1563 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1563 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 0b27d1c 📊 Notices ComparisonNew Errors (2 out of 1563 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1563 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1563 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (6 out of 1563 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1563 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
core/src/main/java/org/mobilitydata/gtfsvalidator/table/AnyTableLoader.java
Outdated
Show resolved
Hide resolved
main/src/main/java/org/mobilitydata/gtfsvalidator/validator/MissingFeedInfoValidator.java
Show resolved
Hide resolved
main/src/test/java/org/mobilitydata/gtfsvalidator/validator/MissingFeedInfoValidatorTest.java
Show resolved
Hide resolved
|
This contribution does not follow the conventions set by the Google Java style guide. Please run the following command line at the root of the project to fix formatting errors: |
…ng_required_file-when-translationstxt-exists
qcdyx
deleted the
1791-feed_infotxt-should-be-added-to-missing_required_file-when-translationstxt-exists
branch
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 8cdbfa5 📊 Notices ComparisonNew Errors (2 out of 1564 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1564 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (6 out of 1564 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
🛡️ Corruption Check0 out of 1564 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
Summary:
Closes #1791
Expected behavior:
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything