Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only display service window on HTML report, not start/end date #1855

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Sep 27, 2024

Summary:

Closes #1854
only display service window on HTML report, not start/end date

Expected behavior:
image

image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 626ae4f
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.06 4.12 ⬆️+0.06
Median -- 1.42 1.49 ⬆️+0.06
Standard Deviation -- 11.49 11.57 ⬆️+0.08
Minimum in References Reports us-california-catalina-express-gtfs-299 0.50 0.64 ⬆️+0.14
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 293.99 296.77 ⬆️+2.78
Minimum in Latest Reports us-oregon-hut-airport-shuttle-gtfs-635 0.61 0.51 ⬇️-0.10
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 293.99 296.77 ⬆️+2.78

@qcdyx qcdyx requested a review from jcpitre September 30, 2024 19:23
Copy link
Contributor

@jcpitre jcpitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 00dd620
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1588 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1588 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 4.10 4.17 ⬆️+0.07
Median -- 1.45 1.51 ⬆️+0.07
Standard Deviation -- 11.66 11.57 ⬇️-0.08
Minimum in References Reports ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 0.51 0.61 ⬆️+0.10
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 291.61 291.03 ⬇️-0.58
Minimum in Latest Reports us-california-flex-v2-developer-test-feed-3-gtfs-1819 0.56 0.58 ⬆️+0.02
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 291.61 291.03 ⬇️-0.58

@qcdyx qcdyx merged commit cf33356 into master Sep 30, 2024
335 checks passed
@qcdyx qcdyx deleted the 1534-service-window-fixes branch September 30, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Service Window only on HTML report
2 participants