feat: new booking_rules.txt validation notices #1866
Conversation
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit de49dd1 📊 Notices ComparisonNew Errors (6 out of 1588 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
@cka-y 1 question for the The notice should be triggered when there is no |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 738e3fb 📊 Notices ComparisonNew Errors (6 out of 1588 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
|
@tzujenchanmbd Great catch! The |
There was a problem hiding this comment.
Thanks @cka-y !
LGTM on notice name, field displayed, and description.
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 4f311d9 📊 Notices ComparisonNew Errors (6 out of 1588 datasets, ~0%) ✅Details of new errors due to code change, which is less than the provided threshold of 1%.
Dropped Errors (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1588 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1588 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
|
Summary:
This pull request enhances the
BookingRulesEntityValidatorby adding new validation checks and corresponding notices. It also updates the test cases to cover these new validations.Added
missing_prior_notice_durantion_min,missing_prior_day_bokking_field_value,forbidden_prior_notice_start_timeandmissing_prior_notice_start_timenotices to the validatorPlease make sure these boxes are checked before submitting your pull request - thanks!
gradle testto make sure you didn't break anything