Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ci fails if no tests folder is added to python function #759

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Oct 9, 2024

Summary:

This pull request includes changes to the execute_python_tests() function in the scripts/api-tests.sh file to improve the logic for determining which directories should contain tests and to generate an error when it doesn't.

Improvements to test execution logic:
Error handling enhancements:

  • scripts/api-tests.sh: Added error messages to handle cases where no tests directory is found in the subdirectories, improving the clarity of test execution failures.
  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y merged commit 30f0c00 into main Oct 16, 2024
3 checks passed
@cka-y cka-y deleted the fix-api-test branch October 16, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants