-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: brand consolodation #778
Conversation
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-778-vnqwad38.web.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🤩
[nit] Noticed a little inconsistency: when hovering over linked elements in https://gtfs-validator.mobilitydata.org/, the color changes, but it doesn’t in the Mobility Database. Maybe we could align the behavior for consistency?
Good point, I checked on the mobilitydata.org website and they have those types of links in the primary colour but they don't change color on hover https://mobilitydata.org/what-we-do/ This gives me the idea that the validator could use some minor UI touch ups |
@Alessandro100 I think the line is good! I agree with @qcdyx that more padding between the homepage heading and the nav line would be good though. I don't think we should design by committee - any more comprehensive visual re-design we do would be with a designer, but I don't anticipate one in the next 3-6 months. This looks great and provides more visual interest on the site! Thanks for this great work. |
b5b2ebb
to
0b61a5d
Compare
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-778-2me386cq.web.app |
closes: #756
Summary:
Mobility database is a product of MobilityData and as such this PR introduces more styling elements to better align with the MobilityData brand as seen on mobilitydata.org
This PR also consolidates random colors and assures that elements on the web app use colors directly from the theme
Biggest changes
Expected behavior:
The application should work the same, just different styling
Testing tips:
Go through the application and try to find visual defects
What's next
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anythingCurrent
After
Active Tab