-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: is official badge + feed detail enhance #870
Conversation
0b814e2
to
696f0e6
Compare
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-870-johoa991.web.app |
0c9551e
to
2a715c0
Compare
Co-authored-by: Jingsi Lu <[email protected]>
@Alessandro100 How are you imagining expanding out "attributes"? Is this where people could also search things like "Flex" or "Fares v2"? |
My thought process behind attributes would be one off filters that would be in high demand but would have a difficult time grouping. For example, if people wanted to filter by Feeds that have no errors I could see Flex and Fares being included in attributes |
@Alessandro100 Makes sense to me. Can we call it "tags"? Seems a little easier to understand to me |
@@ -1,7 +1,9 @@ | |||
-- Query to update official tag for feeds with contact email in the feed table where the source is mdb | |||
|
|||
UPDATE public.feed f | |||
SET official = TRUE | |||
SET | |||
official = TRUE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comma after the first line:
official = TRUE | |
official = TRUE, |
@Alessandro100 the integration tests are failing as they test the branch code with QA DB. In this case, as the PR introduces a new DB column, the QA DB doesn't have the column yet. It's ok to merge it as long it's tested in the DEV environment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes #788
closes #871
Summary:
Feeds Search Page
Feed Detail Page
Styling Fixes
Sx
prop. When you pass andSx
prop with other styles, it's required to manually pass the theme object. If it's just theSx
prop then there is no need to pass the theme object.Expected behavior:
On the Feeds search page, you should be able to see a badge for verified feeds on applicable feeds. You can also search by official feeds. On hover of this badge, should be able to see a tooltip with information
On the Feeds detail page, you should be able to see a badge for verified feed when applicable. You should be able to click the chips of "wanring" "info notice" "errors" and get directed to the quality report. On hover of the verification badge, should display tool tip with information
Testing tips:
On Feed search page, search "london", you'll be able to see a verified feed. You would also be able to use the "Is Official" filter. Assure the badge is there and that the tool tip works
On the feed detail page, try gtfs schedule / gtfs rt feeds and assure all looks good. Check out the official feed and assure the badge looks correct. Official feed
feeds/mdb-2
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anythingTImestamp
![Screenshot 2025-01-10 at 10 38 54](https://private-user-images.githubusercontent.com/18631060/402655827-44f6b48e-c272-4c75-9e6d-1d00af96cccb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg5ODA0ODQsIm5iZiI6MTczODk4MDE4NCwicGF0aCI6Ii8xODYzMTA2MC80MDI2NTU4MjctNDRmNmI0OGUtYzI3Mi00Yzc1LTllNmQtMWQwMGFmOTZjY2NiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDglMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA4VDAyMDMwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJjN2ZhZWZlY2RjNzAyZWY3YmZlYTU1NzM5OGMzOTg4YzRmNzI4NjFlMDE4NTVlMWI2ZDZlN2NkOTM1ODY2NTAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.6DMk5IuIXvvoyrlheeMs2JQEJz8nfm-oN-cLB3bRPy0)