Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: is official badge + feed detail enhance #870

Merged
merged 6 commits into from
Jan 14, 2025

Conversation

Alessandro100
Copy link
Contributor

@Alessandro100 Alessandro100 commented Jan 10, 2025

closes #788
closes #871

Summary:

Feeds Search Page

  • "Is official" badge added on search table
  • Wording added when no feeds are found "Try and change search filters"
  • Ability to filter by official feed [BEHIND FEATURE FLAG]

Feed Detail Page

  • Quality report moved to top of the page -> Chips are now clickable and can go to quality report
  • Icons added to buttons and labels
  • Map visual is larger
  • Official Feed Chip added + timestamp

Styling Fixes

  • Discovered a weird interaction when passing a style to an Sx prop. When you pass and Sx prop with other styles, it's required to manually pass the theme object. If it's just the Sx prop then there is no need to pass the theme object.

Expected behavior:

On the Feeds search page, you should be able to see a badge for verified feeds on applicable feeds. You can also search by official feeds. On hover of this badge, should be able to see a tooltip with information

On the Feeds detail page, you should be able to see a badge for verified feed when applicable. You should be able to click the chips of "wanring" "info notice" "errors" and get directed to the quality report. On hover of the verification badge, should display tool tip with information

Testing tips:

On Feed search page, search "london", you'll be able to see a verified feed. You would also be able to use the "Is Official" filter. Assure the badge is there and that the tool tip works

On the feed detail page, try gtfs schedule / gtfs rt feeds and assure all looks good. Check out the official feed and assure the badge looks correct. Official feed feeds/mdb-2

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

Screenshot 2025-01-09 at 09 29 34

Screenshot 2025-01-09 at 13 31 43

Screenshot 2025-01-09 at 13 35 33

Screenshot 2025-01-09 at 13 37 25

Screenshot 2025-01-09 at 13 37 40

Screenshot 2025-01-09 at 13 38 03

Screenshot 2025-01-09 at 13 35 17

TImestamp
Screenshot 2025-01-10 at 10 38 54

Screenshot 2025-01-13 at 11 46 06

Screenshot 2025-01-13 at 11 47 17

@Alessandro100 Alessandro100 self-assigned this Jan 10, 2025
@Alessandro100 Alessandro100 force-pushed the feat/788-official-feed-ui branch from 0b814e2 to 696f0e6 Compare January 10, 2025 14:12
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-870-johoa991.web.app

@Alessandro100 Alessandro100 force-pushed the feat/788-official-feed-ui branch from 0c9551e to 2a715c0 Compare January 13, 2025 13:51
@emmambd
Copy link
Contributor

emmambd commented Jan 13, 2025

@Alessandro100 How are you imagining expanding out "attributes"? Is this where people could also search things like "Flex" or "Fares v2"?

@Alessandro100
Copy link
Contributor Author

@Alessandro100 How are you imagining expanding out "attributes"? Is this where people could also search things like "Flex" or "Fares v2"?

My thought process behind attributes would be one off filters that would be in high demand but would have a difficult time grouping. For example, if people wanted to filter by Feeds that have no errors

I could see Flex and Fares being included in attributes

@emmambd
Copy link
Contributor

emmambd commented Jan 13, 2025

@Alessandro100 Makes sense to me. Can we call it "tags"? Seems a little easier to understand to me

@@ -1,7 +1,9 @@
-- Query to update official tag for feeds with contact email in the feed table where the source is mdb

UPDATE public.feed f
SET official = TRUE
SET
official = TRUE
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comma after the first line:

Suggested change
official = TRUE
official = TRUE,

@davidgamez
Copy link
Member

@Alessandro100 the integration tests are failing as they test the branch code with QA DB. In this case, as the PR introduces a new DB column, the QA DB doesn't have the column yet. It's ok to merge it as long it's tested in the DEV environment.

Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Alessandro100 Alessandro100 merged commit e5a4c36 into main Jan 14, 2025
6 of 7 checks passed
@Alessandro100 Alessandro100 deleted the feat/788-official-feed-ui branch January 14, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is Official badge verification timestamp in Feed detail page User can see a feed is official in the UI
3 participants