feat: generate new sources.csv from database #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidgamez
reviewed
Jan 28, 2025
| @@ -318,18 +318,18 @@ jobs: | |||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
| PLAN_OUTPUT: ${{ steps.plan.outputs.stdout }} | |||
|
|
|||
| - name: Persist TF plan | |||
Comment on lines
16
to
17
| "max_instance_request_concurrency": 20, | ||
| "max_instance_count": 10, |
There was a problem hiding this comment.
Let's use set the number of instances to one:
Suggested change
| "max_instance_request_concurrency": 20, | |
| "max_instance_count": 10, | |
| "max_instance_request_concurrency": 1, | |
| "max_instance_count": 1, |
| :return: A filled DataCollector | ||
| """ | ||
| db = Database(database_url=os.getenv("FEEDS_DATABASE_URL")) | ||
| print(f"Using database {db.database_url}") |
There was a problem hiding this comment.
We should use the logger for GCP. Example: https://github.com/MobilityData/mobility-feed-api/blob/e59d9568c3bd913c32144519827722301e80ebaa/functions-python/batch_process_dataset/src/main.py#L37 and
jcpitre
changed the title
davidgamez
reviewed
Jan 28, 2025
Co-authored-by: David Gamez <[email protected]>
jcpitre
deleted the
779-generate-new-sourcescsv-from-postgresql-database2
branch
jcpitre
changed the title
This was referenced Jan 31, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
closes #779
Also moved some libraries into the shared folder, so a bunch of changes are just modification to the import.
Expected behavior:
After running the cloud function, the file https://storage.googleapis.com/mobilitydata-datasets-dev/sources_v2.csv should contain the contents of the DB
Testing tips:
Painstakingly look at the result csv and see if it makes sense.
Deployment can be tested by running the api-dev.yml and then triggering the function.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.shto make sure you didn't break anything