feat: initial windows support #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @steinwurf-sofie, thanks for this PR! Could you please resolve the conflicts? After that will review it. |
steinwurf-sofie
force-pushed
the
feat/win-support
branch
from
7d9e123
to
5adc706
Compare
|
Hi, @MonolithProjects I have now resolved the conflicts. 👍 |
steinwurf-sofie
had a problem deploying
to
test
GitHub Actions
Error
steinwurf-sofie
had a problem deploying
to
test
GitHub Actions
Error
steinwurf-sofie
had a problem deploying
to
test
GitHub Actions
Error
steinwurf-sofie
had a problem deploying
to
test
GitHub Actions
Error
steinwurf-sofie
had a problem deploying
to
test
GitHub Actions
Error
MonolithProjects
merged commit 5e08b29
into
MonolithProjects:develop
3 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworked and added support for windows, following closely to how the unix-like tasks were written. Tested locally.
Currently unsure how to approach writing up molecule tests for this, as molecule seems particularly unhappy about Windows.
Opened PR for feedback, and thanks for this project! 😄
Type of change
How Has This Been Tested?
Only tested manually thus far.
reinstall_runner,started,stopped, andabsenthave all been tested and verified that they function correctly and are idempotent.