Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation guides for contributions, testing and code of conduct #196

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lcrojano
Copy link

This pr closes #195 by adding:

CODE-OF-CONDUCT.md
Establishes guidelines for contributing respectfully, ensuring a positive and inclusive community atmosphere.

docs/CONTRIBUTING.md
Details contribution instructions, including pull request guidelines and coding standards to streamline the contribution process.

docs/CYPRESS-TESTING-GUIDE.md
Provides a comprehensive setup and usage guide for end-to-end testing with Cypress, tailored for this project’s structure.

docs/JEST-TESTING-GUIDE.md
Outlines steps for configuring and executing unit and integration tests using Jest, helping maintain code reliability and quality.

docs/SETUP-GUIDE.md
Step-by-step installation and configuration guide for newcomers to quickly get Apollusia up and running locally.

@Morphclue Morphclue self-requested a review October 29, 2024 16:52
@Morphclue Morphclue added documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest This issue is related to Hacktoberfest labels Oct 29, 2024
docs/CONTRIBUTING.md Outdated Show resolved Hide resolved
```shell
git clone --depth 1 --branch master https://github.com/Morphclue/apollusia
cd apollusia
docker compose up -d
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For local development, it’s generally better to use pnpm commands for the frontend and backend, as it provides faster rebuild times and smoother debugging. So I would advise developers to only start the database / keycloak containers.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lcrojano
I've added a new docker-compose file that can be used for dev-setup.
It can be started with docker-compose -f docker-compose.dev.yml up and after that pnpm serve:frontend and pnpm serve:backend should be used. Either with 3 terminals or 2 and a -d detach flag for compose.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also get rid of this section and all the related information that is already mentioned in the SETUP-GUIDE.

docs/CYPRESS-TESTING-GUIDE.md Outdated Show resolved Hide resolved
docs/SETUP-GUIDE.md Outdated Show resolved Hide resolved
docs/CYPRESS-TESTING-GUIDE.md Outdated Show resolved Hide resolved
docs/JEST-TESTING-GUIDE.md Outdated Show resolved Hide resolved
@Morphclue Morphclue requested a review from Clashsoft October 29, 2024 17:22
Copy link
Author

@lcrojano lcrojano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made suggested changes and some proposals; feel free to tell me what you think I'm willing to collaborate on further.

docs/CYPRESS-TESTING-GUIDE.md Outdated Show resolved Hide resolved
docs/SETUP-GUIDE.md Outdated Show resolved Hide resolved
docs/JEST-TESTING-GUIDE.md Outdated Show resolved Hide resolved
Comment on lines -105 to -127
Create an `.env` file in the backend directory and add the following environment variables:

```properties
EMAIL_HOST=<smtp host>
EMAIL_PORT=25 # optional, alternatively 587, or 465 for SSL
EMAIL_SSL=false # optional
EMAIL_STARTTLS=false # optional
EMAIL_USER=<username>
EMAIL_PASSWORD=<password>
EMAIL_FROM=<sender email>
EMAIL_NAME=Apollusia # optional sender display name
VAPID_PUBLIC_KEY=<vapid public key> # for push notifications
VAPID_PRIVATE_KEY=<vapid private key> # for push notifications
CONTACT_OPERATOR=<contact operator>
CONTACT_MAIL=<contact email>
CONTACT_ADDRESS=<contact address>
```

VAPID keys can be generated using the following command:

```bash
npx web-push generate-vapid-keys
```
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just noticed that this section is also missing completly.

```shell
git clone --depth 1 --branch master https://github.com/Morphclue/apollusia
cd apollusia
docker compose up -d
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably also get rid of this section and all the related information that is already mentioned in the SETUP-GUIDE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request hacktoberfest This issue is related to Hacktoberfest
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

include CONTRIBUTING.md. To improve community contributions,
2 participants