Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GitHub Sort Content) In user repos lists the sort arrow is not displayed initially, and when you click to sort then the arrow is displayed multiple times #5

Closed
darkred opened this issue Aug 20, 2016 · 9 comments

Comments

@darkred
Copy link
Collaborator

darkred commented Aug 20, 2016

I've noticed this minor issue in user repos lists: (GSC 1.0.3 in FF 48, GM 3.9, win 10):
the sort up/down arrow is not displayed (initially),
and when you click in the area to sort then the sort arrow is displayed multiple times filling the row.

Screenshot from e.g. https://github.com/addyosmani?tab=repositories
2016-08-20_181648


PS. Mottie, btw, could you please tell what GIF capture program did you use in order to make the 3 gif screen captures in [here](https://github.com/Mottie/GitHub-userscripts/wiki/GitHub-sort-content)?
@darkred darkred changed the title (GitHub Sort Content) In pinned repos lists the sort arrow is not displayed initially, and when you click to sort in the area then the arrow is displayed multiple times (GitHub Sort Content) In pinned repos lists the sort arrow is not displayed initially, and when you click to sort then the arrow is displayed multiple times Aug 20, 2016
@Mottie
Copy link
Owner

Mottie commented Aug 20, 2016

Hi @darkred!

Odd, I can't seem to duplicate the background repeat on pinned repos... I'll go ahead and add a no-repeat anyway.

I use LICEcap to make the animated screenshots. Sometimes I end up editing them in Photoshop to remove frames or add labels.

@darkred
Copy link
Collaborator Author

darkred commented Aug 20, 2016

Thank you very much.
I have also tried it in a clean FF48 profile with only GM and the script, and it occurs too.

@Mottie Mottie closed this as completed in f507d13 Aug 20, 2016
@Mottie
Copy link
Owner

Mottie commented Aug 20, 2016

Please check and make sure this update fixes the problem.

@darkred
Copy link
Collaborator Author

darkred commented Aug 20, 2016

Yes, the update fixes the issue.
It's just that:

  • initially the sort arrow is still not displayed:
    2016-08-20_193959



  • if you click to sort, then the arrow now is displayed on top of the Mirrors link:
    2016-08-20_192512
    Could you please move the arrow to the left of All ?
    I'd suggest changing the two lines of your commit
    from background-position:calc(100% - 5px) center !important;
    to background-position:calc(100% - 200px) center !important;
    i.e. in order to be displayed :
    2016-08-20_193601
    Though, the above needs some additional change, because now the arrow is displayed next to All only on ascending sorting - on descending sorting it is displayed to its previous position.

@Mottie
Copy link
Owner

Mottie commented Aug 20, 2016

Ahh, I see why it stopped working... GitHub changed some class names.

@Mottie
Copy link
Owner

Mottie commented Aug 20, 2016

Ok, try the script now... I wasn't paying attention initially when I said I couldn't duplicate the problem, it's because I was looking at a user's pinned repos, but the screenshot is from the user's repo tab .

@darkred darkred changed the title (GitHub Sort Content) In pinned repos lists the sort arrow is not displayed initially, and when you click to sort then the arrow is displayed multiple times (GitHub Sort Content) In user repos lists the sort arrow is not displayed initially, and when you click to sort then the arrow is displayed multiple times Aug 20, 2016
@darkred
Copy link
Collaborator Author

darkred commented Aug 20, 2016

I'm really sorry...
I want to be careful, but that's the 3rd mistake in a row that I made... (yesterday, posting an issue in the wrong repo, and then misunderstanding that you told me not to post another issue) and now this...
I feel ashamed...

@Mottie
Copy link
Owner

Mottie commented Aug 20, 2016

LOL no worries

@darkred
Copy link
Collaborator Author

darkred commented Aug 20, 2016

Yes, the issue is fixed now 👍
Thanks for your understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants