Add a Danger rule to check for (simultaneous) changes in CocoaPods / Carthage files #808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 83.05% (diff: 100%)@@ master #808 diff @@
==========================================
Files 34 34
Lines 2738 2738
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2274 2274
Misses 464 464
Partials 0 0
|
pedrovereza
reviewed
Nov 29, 2016
| cartfile_updated = !git.modified_files.grep(/Cartfile).empty? | ||
| cartfile_resolved_updated = !git.modified_files.grep(/Cartfile.resolved).empty? | ||
|
|
||
| if podspec_updated && !cartfile_updated && !cartfile_resolved_updated |
There was a problem hiding this comment.
Shouldn't this be
if podspec_updated && (!cartfile_updated || !cartfile_resolved_updated)just like line 46?
There was a problem hiding this comment.
You're right. Changed.
ashfurrow
approved these changes
Nov 30, 2016
SwiftLint found issuesWarnings
Generated by 🚫 danger |
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #796.
Can we somehow check if this works as intended? I couldn't really find a way to do so.