added redux notification on unreachable error

MyCryptoHQ · Nov 12, 2017 · 1646392 · 1646392
1 parent 0e7ec3d
commit 1646392
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 35 deletions.
diff --git a/common/components/BalanceSidebar/AccountInfo.tsx b/common/components/BalanceSidebar/AccountInfo.tsx
@@ -91,28 +91,28 @@ export default class AccountInfo extends React.Component<Props, State> {
         </div>
 
         {(!!blockExplorer || !!tokenExplorer) && (
-            <div className="AccountInfo-section">
-              <h5 className="AccountInfo-section-header">
-                {translate('sidebar_TransHistory')}
-              </h5>
-              <ul className="AccountInfo-list">
-                {!!blockExplorer && (
-                  <li className="AccountInfo-list-item">
-                    <a href={blockExplorer.address(address)} target="_blank">
-                      {`${network.name} (${blockExplorer.name})`}
-                    </a>
-                  </li>
-                )}
-                {!!tokenExplorer && (
-                  <li className="AccountInfo-list-item">
-                    <a href={tokenExplorer.address(address)} target="_blank">
-                      {`Tokens (${tokenExplorer.name})`}
-                    </a>
-                  </li>
-                )}
-              </ul>
-            </div>
-          )}
+          <div className="AccountInfo-section">
+            <h5 className="AccountInfo-section-header">
+              {translate('sidebar_TransHistory')}
+            </h5>
+            <ul className="AccountInfo-list">
+              {!!blockExplorer && (
+                <li className="AccountInfo-list-item">
+                  <a href={blockExplorer.address(address)} target="_blank">
+                    {`${network.name} (${blockExplorer.name})`}
+                  </a>
+                </li>
+              )}
+              {!!tokenExplorer && (
+                <li className="AccountInfo-list-item">
+                  <a href={tokenExplorer.address(address)} target="_blank">
+                    {`Tokens (${tokenExplorer.name})`}
+                  </a>
+                </li>
+              )}
+            </ul>
+          </div>
+        )}
       </div>
     );
   }

diff --git a/common/containers/Tabs/Swap/components/CurrencySwap.tsx b/common/containers/Tabs/Swap/components/CurrencySwap.tsx
@@ -109,7 +109,20 @@ export default class CurrencySwap extends Component<
             minAmount = toFixedIfLarger(REPMin, 3);
             break;
           default:
-            console.warn('Something went terribly wrong!');
+            if (this.state.showedMinMaxError) {
+              this.setState(
+                {
+                  showedMinMaxError: true
+                },
+                () => {
+                  this.props.showNotification(
+                    'danger',
+                    "Couldn't get match currency kind. Something went terribly wrong",
+                    10000
+                  );
+                }
+              );
+            }
         }
         return { minAmount, maxAmount };
       };
@@ -237,19 +250,22 @@ export default class CurrencySwap extends Component<
             <div className="CurrencySwap-input-group">
               <span className="CurrencySwap-error-message">{originErr}</span>
               <input
-                className={`CurrencySwap-input form-control ${String(
-                  originAmount
-                ) !== '' && this.isMinMaxValid(originAmount, originKind)
-                  ? 'is-valid'
-                  : 'is-invalid'}`}
+                className={`CurrencySwap-input form-control ${
+                  String(originAmount) !== '' &&
+                  this.isMinMaxValid(originAmount, originKind)
+                    ? 'is-valid'
+                    : 'is-invalid'
+                }`}
                 type="number"
                 placeholder="Amount"
                 value={originAmount || originAmount === 0 ? originAmount : ''}
                 onChange={this.onChangeOriginAmount}
               />
               <div className="CurrencySwap-dropdown">
                 <OriginKindDropDown
-                  ariaLabel={`change origin kind. current origin kind ${originKind}`}
+                  ariaLabel={`change origin kind. current origin kind ${
+                    originKind
+                  }`}
                   options={originKindOptions}
                   value={originKind}
                   onChange={this.props.originKindSwap}
@@ -264,11 +280,12 @@ export default class CurrencySwap extends Component<
                 {destinationErr}
               </span>
               <input
-                className={`CurrencySwap-input form-control ${String(
-                  destinationAmount
-                ) !== '' && this.isMinMaxValid(originAmount, originKind)
-                  ? 'is-valid'
-                  : 'is-invalid'}`}
+                className={`CurrencySwap-input form-control ${
+                  String(destinationAmount) !== '' &&
+                  this.isMinMaxValid(originAmount, originKind)
+                    ? 'is-valid'
+                    : 'is-invalid'
+                }`}
                 type="number"
                 placeholder="Amount"
                 value={
@@ -280,7 +297,9 @@ export default class CurrencySwap extends Component<
               />
               <div className="CurrencySwap-dropdown">
                 <DestinationKindDropDown
-                  ariaLabel={`change destination kind. current destination kind ${destinationKind}`}
+                  ariaLabel={`change destination kind. current destination kind ${
+                    destinationKind
+                  }`}
                   options={destinationKindOptions}
                   value={destinationKind}
                   onChange={this.props.destinationKindSwap}