Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw on CryptoCompare API error #486

Merged
merged 3 commits into from
Nov 29, 2017
Merged

Throw on CryptoCompare API error #486

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d20521
Throw properly on API error.
wbobeirne Nov 28, 2017
9c70807
remove console
dternyak Nov 29, 2017
b83f54f
Merge branch 'develop' into throw-cryptocompare-error
dternyak Nov 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions common/actions/rates/actionPayloads.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ export const fetchRates = (symbols: string[] = []): Promise<CCResponse> =>
fetch(CCRates(symbols))
.then(response => handleJSONResponse(response, ERROR_MESSAGE))
.then(rates => {
// API errors come as 200s, so check the json for error
if (rates.Response && rates.Response === 'Error') {
throw new Error('Failed to fetch rates');
}

// All currencies are in ETH right now. We'll do token -> eth -> value to
// do it all in one request
// to their respective rates via ETH.
Expand Down