Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

feat/ read mark1 eye color #2471

Merged
merged 2 commits into from
Mar 30, 2020
Merged

feat/ read mark1 eye color #2471

merged 2 commits into from
Mar 30, 2020

Conversation

JarbasAl
Copy link
Contributor

Description

Adds a mechanism to query the current eye color for the mark1

There is no way to get this info from the arduino directly, instead this keeps track of every change in the Enclosure class

How to test

pixels = self.enclosure.get_eyes_color()
individual_pixel = self.enclosure.get_eyes_pixel_color(idx)

Contributor license agreement signed?

CLA [y] (Whether you have signed a CLA - Contributor Licensing Agreement

@JarbasAl JarbasAl added Type: Enhancement - proposed New proposal for a feature that is not currently a priority on the roadmap. platform: mark1 labels Feb 11, 2020
@devs-mycroft devs-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Feb 11, 2020
@forslund
Copy link
Collaborator

forslund commented Feb 12, 2020

Works very well 👍

Just a tiny nitpick can you look at the docstrings and make them in the same style as the rest?

The summary line at the same line as """ and a Returns: section

Ex:

        """Get the eye RGB color for all pixels
        Returns:
           (list) list of (r,g,b) tuples for each eye pixel
        """

@forslund forslund self-requested a review February 13, 2020 19:18
Copy link
Collaborator

@forslund forslund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the docstrings I don't see anything. Tested and works just fine. will merge after that is fixed.

@forslund
Copy link
Collaborator

Seems like this needs a rebase as well to fix the conflicts.

@forslund
Copy link
Collaborator

I would still like to see the docstrings updated to conform with the Mycroft standard.

@JarbasAl
Copy link
Contributor Author

done, i had changed in the mark1 folder but missed it under the enclosure folder

@forslund
Copy link
Collaborator

Very nice, I fixed up the commit history a bit, merging now.

@forslund forslund merged commit 34b242b into MycroftAI:dev Mar 30, 2020
@JarbasAl JarbasAl deleted the feat/get_eye_color branch March 30, 2020 14:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Type: Enhancement - proposed New proposal for a feature that is not currently a priority on the roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants