This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Update the ESpeak TTS plugin #2581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes wait_while_speaking - Adds Caching support
devs-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
An underscore instead of a . made the subprocess check output always pass.
forslund
force-pushed
the
bugfix/tts-espeak-update
branch
from
39986a4
to
8c0aca6
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
This also normalizes the path slightly to make sure that the phonetic spelling is loaded even if the lang code contains capitals.
|
Voight Kampff Integration Test Succeeded (Results) |
|
Works great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The espeak output was done directly from the espeak executable and not through the TTS output queue, this makes the ESpeak module work more like mimic, mimic2 etc.
This should resolve #2579 allowing wait_while_speaking to work in a better fashion.
This also adds a simple test case for the espeak module and fixes a typo in a mimic-test
How to test
Assert that ESpeak output works as previously.
Contributor license agreement signed?
CLA [ Yes ]