This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Bugfix/remove fallback handler #2588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
reviewed
May 19, 2020
remove_fallback() was mainly created for use internally during shutdown and required the wrapped callable to be able to remove a handler. This makes it general, using a mapping to find the wrapper from a handler if needed. The method now also returns the success/failure status
forslund
force-pushed
the
bugfix/remove-fallback-handler
branch
from
6cc712d
to
010562f
Compare
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow removal of a fallback handler without knowing the wrapper. Fixes #2586
How to test
Check that the new tests pass and make sure fallback query can be reloaded correctly.
Contributor license agreement signed?
CLA [ Yes ]