This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Chat user hniazi discovered that the
duration_stretch
setting wasn't updated as expected when configuration was updated. It turned out the method looked a global scoped config and not the object specific config. This fixes that issue.It also changes the global variable names to uppercase to make this kind of issue harder happen again.
How to test
Add a tts section to your user's config file
then trigger a config reload
python -m mycroft.messagebus.send "configuration.updated"
Make mycroft talk to hear the slower speech
Change the value to something like "0.5" trigger an update again and make sure mycroft now talks really fast.
Contributor license agreement signed?
CLA [ Yes ]