This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Enable utf-8 encoding during dev-setup.sh #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devs-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
forslund
added
the
Type: Bug - quick
krisgesling
reviewed
Nov 4, 2020
krisgesling
approved these changes
Nov 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapt fails to install due to an encoding issue, this was originally reported here.
This enables utf-8 in the dev_setup.sh script to fix this issue.
How to test
Ensure dev_setup.sh manages to complete successfully. I removed adapt and added the
--no-cacheflag to the pip command on L514 to ensure that the error would occur.Contributor license agreement signed?
CLA [ Yes ] (Whether you have signed a CLA - Contributor Licensing Agreement