This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Send correct conf to mimic when used as fallback #2829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mimic is now sent the correct config when used as a fallback - Tests updated to ensure this
devops-mycroft
added
the
CLA: Yes
|
Voight Kampff Integration Test Succeeded (Results) |
forslund
force-pushed
the
bugfix/fallback-to-mimic-config
branch
from
6cd131c
to
dac3bb8
Compare
|
Included commit from #2830 to make the unit tests pass. |
|
Voight Kampff Integration Test Succeeded (Results) |
1 similar comment
|
Voight Kampff Integration Test Succeeded (Results) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When testing PR #2828 I noticed mimic could fail to load properly as fallback. Basically it sent the config for the failed tts instead of the fallback.
How to test
Ensure unittests pass
Contributor license agreement signed?
CLA [ Yes ]