[wallet-kit] Wallet Kit Core #6950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jordan-Mysten
requested review from
Jibz1,
pchrysochoidis,
kristaki90 and
georgedigkas
Jordan-Mysten
requested review from
randall-Mysten and
ronny-mysten
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
pchrysochoidis
approved these changes
Jan 3, 2023
Jordan-Mysten
force-pushed
the
jordan--wallet-kit-core-rework
branch
from
49ccb0f to
daf8e20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the WalletKit logic into a core, framework-agnostic package.
While we don't plan on supporting other UI libraries in the very near-term, this could help bootstrap community efforts, as they could leverage the core package to implement similar behavior in their own UI. The API is as minimal as I could make it, and the state model should easily incorporate into anything.
As a neat aside, it's also Svelte Store compatible.