[TypeScript SDK] Fix websocket port #7637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
666lcz
force-pushed
the
chris-fix-port
branch
from
7d14ac5 to
391122a
Compare
666lcz
force-pushed
the
chris-fix-port
branch
from
391122a to
4fe69b8
Compare
| @@ -13,7 +13,14 @@ import { Client as WsRpcClient } from 'rpc-websockets'; | |||
| export const getWebsocketUrl = (httpUrl: string, port?: number): string => { | |||
| const url = new URL(httpUrl); | |||
| url.protocol = url.protocol.replace('http', 'ws'); | |||
| url.port = (port ?? 9001).toString(); | |||
| if (!url.port) { | |||
There was a problem hiding this comment.
URL ignores the default ports, for example doing something like
const url = new URL('http://example.com:80')
console.log(url.port); // ''
port will be empty same for https. So this will always throw if we use default port without passing the port parameter.
I don't think we should throw errors if port is not set. If not set it will mean the default port for the scheme (http/ws -> 80, https/wss -> 443)
pchrysochoidis
added a commit
that referenced
this pull request
Jan 25, 2023
[This change](#7637) breaks wallet and explorer. Doing [this](https://github.com/MystenLabs/sui/pull/7637/files#r1086606234) to fix it
williampsmith
pushed a commit
that referenced
this pull request
Feb 3, 2023
williampsmith
pushed a commit
that referenced
this pull request
Feb 3, 2023
[This change](#7637) breaks wallet and explorer. Doing [this](https://github.com/MystenLabs/sui/pull/7637/files#r1086606234) to fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7546