Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

feat: Allow audio pre-buffering #570

Merged
merged 3 commits into from
Jul 31, 2022
Merged

feat: Allow audio pre-buffering #570

merged 3 commits into from
Jul 31, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This PR allows for pre-buffering audio before playing. This is a very niche use, and most of the time shouldn't be necessary.

requested by @Catalyst4222

Changes

  • Allow create_process not to block
  • Add check for buffer initialisation in read task
  • Add pre_buffer method
  • Remove unnecessary audio cleanup from player start

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the New Feature::Library A new feature for the library label Jul 26, 2022
@LordOfPolls LordOfPolls merged commit 2a0f5ce into dev Jul 31, 2022
@LordOfPolls LordOfPolls deleted the audio-pre-buffer branch July 31, 2022 15:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
New Feature::Library A new feature for the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LordOfPolls