Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: proeperly remove alias for prefixed cmd's remove_command #574

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

AstreaTSS
Copy link
Contributor

@AstreaTSS AstreaTSS commented Jul 29, 2022

What type of pull request is this?

  • Non-breaking code change (okay, technically this is breaking, but this wasn't intended anyways)
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Adjusts PrefixedCommand.remove_command so that, if an alias is passed, it also removes the alias from the main command itself (instead of only removing the alias entry from the dict of subcommands).

Changes

...see above.

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@AstreaTSS AstreaTSS changed the base branch from master to dev July 29, 2022 18:26
@LordOfPolls LordOfPolls added the Bug::Library A bug in the library label Jul 29, 2022
@LordOfPolls LordOfPolls merged commit 72b8820 into NAFTeam:dev Jul 29, 2022
@AstreaTSS AstreaTSS deleted the remove-alias-pre-cmd branch July 31, 2022 19:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug::Library A bug in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants