This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix: allow coroutines for prefixed commands #581
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
While coroutine functions were always intended to work with prefixed commands if you used them in an annotation, it turns out the support to them was broken. This fixes that.
As a fun side effect, this also may fix a couple of other cases where functions weren't being properly parsed.
Changes
isroutine
instead ofisfunction
to ensure the function is caught in all cases.inspect.iscoroutinefunction
from doing its job).maybe_coroutine
for the actual function itself.Checklist
Python 3.10.x