Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: parse NoArgumentConverter correctly #584

Merged
merged 2 commits into from
Aug 2, 2022

Conversation

AstreaTSS
Copy link
Contributor

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This PR fixes a number of issues that NoArgumentConverter has, detecting if it's a class and filling NoArgumentConverters in even after all of the arguments have been exhausted.

...this is what hybrid commands do to you.

Changes

  • Move out NoArgumentConverter checking to its own function.
  • Add in an extra check to see if the annotation was possibly a class and a subclass of NoArgumentConverter.
  • Fill in NoArgumentConverter even after all of the parameters have been "exhausted".

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls merged commit 52412fd into NAFTeam:dev Aug 2, 2022
@AstreaTSS AstreaTSS deleted the no-arg-class branch August 2, 2022 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants