This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
feat: add hybrid commands #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is different from every other one of the contexts in that get_context is not where it is created, as it is a wrapper for two other contexts instead. This shouldn't really matter too much, though.
I'd figured this was safer than hoping they read the logger.
|
Can you go into tests/test_protocols.py and a check that Hybrid contexts are SendableContexts? |
|
Done! |
LordOfPolls
reviewed
Aug 4, 2022
LordOfPolls
approved these changes
Aug 5, 2022
|
Due to the scope of this PR it should not be merged until we have at least a second trust-worthy reviewer That said if it hits 14 days since my review without a second, it'll be merged |
LordOfPolls
added
New Feature::Library
|
Found a little oversight - |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
This PR adds hybrid commands, which allow using a slash command as a prefixed command too. Efforts have been taken to make sure the resulting prefixed command is as close to the slash command as possible.
This PR also, mostly by consequence:
HybridContext. An argument has been added toClientto allow setting a custom subclass ofHybridContext, too.kindtoPrefixedCommandParameter.Due to the many, many ways slash commands can be declared, there may be some bugs that I missed (though I did test a number of combinations and options).
Changes
See above. Usually, I would type something out, but I feel like this would be a repeat of the description if I bothered.
Checklist
Python 3.10.x