Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: use to_snowflake for remove_role #589

Merged
merged 1 commit into from
Aug 10, 2022

Conversation

AstreaTSS
Copy link
Contributor

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This makes Member.remove_role use to_snowflake instead of getting the ID directly, which can result in getting a SnowflakeObject which obviously isn't ideal.

Changes

  • Replace the isinstance check with a to_snowflake call in remove_role.

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls merged commit b9154e4 into NAFTeam:dev Aug 10, 2022
@AstreaTSS AstreaTSS deleted the remove-role-fix branch August 11, 2022 23:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants