Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: pass error in extension_error handler #612

Merged
merged 1 commit into from
Aug 22, 2022
Merged

fix: pass error in extension_error handler #612

merged 1 commit into from
Aug 22, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Breaking in the event someone was using this blatantly broken method.

This pr means that the extension error handller is actually passed the error

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Bug::Library A bug in the library label Aug 21, 2022
silasary
silasary approved these changes Aug 22, 2022
View reviewed changes
Copy link
Collaborator

@silasary silasary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh

@LordOfPolls LordOfPolls merged commit 50ef1e6 into dev Aug 22, 2022
@LordOfPolls LordOfPolls deleted the ext_error branch August 22, 2022 06:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
Bug::Library A bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordOfPolls @silasary