This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
feat: use async iterator to speedup http chunking #620
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
This pr further speeds up guild chunking by leveraging the AsyncIterator to fetch members. This means the bot caches members as it fetches them, rather than fetching them all then caching. It also resolves the blocking problem as the async iterator wont block the event loop.
Overall this is only a ~10% speed improvement per chunk, but every little helps.
Changes
Checklist
Python 3.10.x