Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: Typing of some create_guild parameters #626

Merged
merged 1 commit into from
Sep 7, 2022
Merged

fix: Typing of some create_guild parameters #626

merged 1 commit into from
Sep 7, 2022

Conversation

benwoo1110
Copy link
Contributor

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Fix some typing issues that I spotted based on a todo, totally not scrolling through all the todos rn

Changes

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added Documentation A documentation change Improvement Something that is already implemented but can be done better labels Sep 6, 2022
silasary
silasary approved these changes Sep 7, 2022
View reviewed changes
Copy link
Collaborator

@silasary silasary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@LordOfPolls LordOfPolls merged commit dd06e05 into dev Sep 7, 2022
@LordOfPolls LordOfPolls deleted the guild-create-typing branch September 7, 2022 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
Documentation A documentation change Improvement Something that is already implemented but can be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benwoo1110 @silasary @LordOfPolls