Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

feat 💥: fire async start methods as soon as possible #631

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

This pr moves the execution of async startup tasks from after the websocket has connected, to before the client has even attempted to connect to the gateway.

Changes

  • As above

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Improvement Something that is already implemented but can be done better label Sep 9, 2022
@LordOfPolls LordOfPolls changed the base branch from dev to 2.x September 9, 2022 10:01
@LordOfPolls LordOfPolls merged commit 8ef633f into 2.x Sep 14, 2022
@LordOfPolls LordOfPolls deleted the fire-async-start-asap branch September 14, 2022 17:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Improvement Something that is already implemented but can be done better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants