Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

feat 💥: Forums rewrite #646

Merged
merged 19 commits into from
Sep 25, 2022
Merged

feat 💥: Forums rewrite #646

merged 19 commits into from
Sep 25, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Rewrites / ammends the forum implimentation to be more user friendly, and inline with the spec

Changes

  • Update create post endpoint from private-beta code to spec
  • Add NewThreadCreate event that only dispatches for brand new threads
  • Add list_posts method to forums
  • Add fetch_post method to forums
  • Add get_post method to forums
  • Add get_tag method to forums
  • Update forum create_post to handle string, int, and object available tags

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added New Feature::Discord Adding support for a new discord feature New Feature::Library A new feature for the library labels Sep 15, 2022
Copy link
Member

@Kigstn Kigstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gonna test this over the next days. But for now support for pinning posts is missing

naff/models/discord/channel.py Outdated Show resolved Hide resolved
naff/models/discord/channel.py Outdated Show resolved Hide resolved
naff/models/discord/channel.py Show resolved Hide resolved
Copy link
Member

@Kigstn Kigstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create_tag() currently requires an emoji, this needs to be optional

naff/models/discord/channel.py Show resolved Hide resolved
@LordOfPolls LordOfPolls merged commit 3f0d211 into 2.x Sep 25, 2022
@LordOfPolls LordOfPolls deleted the forums-rewrite branch September 25, 2022 15:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
New Feature::Discord Adding support for a new discord feature New Feature::Library A new feature for the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants