This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix: properly remove deleted channel from cache #648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
The processor for channel deletion was not properly deleting the channel from the cache, instead just deleting from the guild's list of channels. This change makes sure that not even
bot.get_channel
or the like can get the deleted channel.Changes
delete_channel
function in the cache rather than trying to handle the deletion logic in the channel deletion processor.Checklist
Python 3.10.x