Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: properly remove deleted channel from cache #648

Merged
merged 3 commits into from
Sep 17, 2022

Conversation

AstreaTSS
Copy link
Contributor

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

The processor for channel deletion was not properly deleting the channel from the cache, instead just deleting from the guild's list of channels. This change makes sure that not even bot.get_channel or the like can get the deleted channel.

Changes

  • Use the delete_channel function in the cache rather than trying to handle the deletion logic in the channel deletion processor.
  • Update the comment for this to clarify what's going on with the fix.

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls merged commit 3c422b6 into NAFTeam:dev Sep 17, 2022
@AstreaTSS AstreaTSS deleted the chan-delete-fix branch November 24, 2022 19:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants