Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: Correct the type annotations for extension parameters #657

Merged
merged 2 commits into from
Sep 27, 2022
Merged

Conversation

silasary
Copy link
Collaborator

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

When annotating a **param, you don't need to state that it's a mapping of string, that's implicit.
The annotation is automatically Mapping[str, T]. So we were accidentally saying that people could only have dicts as parameters to load_extension.

Also some docs improvements while I'm in here :P

Changes

  • docs: Remove duplicated parameters and add send_command_tracebacks to Client.init's documentation
  • fix: Correct the type annotations for extension parameters

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls merged commit 40d3891 into dev Sep 27, 2022
@LordOfPolls LordOfPolls deleted the typing branch October 17, 2022 18:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants