This repository has been archived by the owner on Mar 13, 2023. It is now read-only.
fix: Correct the type annotations for extension parameters #657
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of pull request is this?
Description
When annotating a
**param
, you don't need to state that it's a mapping of string, that's implicit.The annotation is automatically Mapping[str, T]. So we were accidentally saying that people could only have dicts as parameters to load_extension.
Also some docs improvements while I'm in here :P
Changes
Checklist
Python 3.10.x