Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

fix: remove no_export attributes when using as_dict #665

Merged
merged 1 commit into from
Oct 18, 2022
Merged

fix: remove no_export attributes when using as_dict #665

merged 1 commit into from
Oct 18, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Removes attributes marked as no export when using as_dict

Resolves issues syncing with new logger addition

Changes

  • as above

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Bug::Library A bug in the library label Oct 14, 2022
Kigstn
Kigstn approved these changes Oct 18, 2022
View reviewed changes
Copy link
Member

@Kigstn Kigstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :D

@LordOfPolls LordOfPolls merged commit badf603 into 2.x Oct 18, 2022
@LordOfPolls LordOfPolls deleted the fix-serialization branch November 14, 2022 09:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Kigstn Kigstn Kigstn approved these changes

Assignees
No one assigned
Labels
Bug::Library A bug in the library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordOfPolls @Kigstn