Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

refactor 💥: Make component event consistent with other events #669

Merged
merged 1 commit into from
Oct 16, 2022
Merged

refactor 💥: Make component event consistent with other events #669

merged 1 commit into from
Oct 16, 2022

Conversation

LordOfPolls
Copy link
Member

@LordOfPolls LordOfPolls commented Oct 15, 2022 •
edited
Loading

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

All other events use ctx, this one uses context. This is annoying

Changes

  • Renames Component.context -> Component.ctx

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Improvement Something that is already implemented but can be done better label Oct 15, 2022
@LordOfPolls LordOfPolls merged commit ac62045 into 2.x Oct 16, 2022
@LordOfPolls LordOfPolls deleted the consistent_context branch October 16, 2022 06:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
Improvement Something that is already implemented but can be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordOfPolls @silasary