Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

refactor 💥: Rename button event to prevent overlap #670

Merged
merged 2 commits into from
Oct 16, 2022
Merged

refactor 💥: Rename button event to prevent overlap #670

merged 2 commits into from
Oct 16, 2022

Conversation

LordOfPolls
Copy link
Member

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change

Description

Renames Button event to ButtonEvent as the overlap is really annoying to deal with

Changes

  • As above

Checklist

  • I've formatted my code with Black
  • I've ensured my code works on Python 3.10.x
  • I've tested my code

@LordOfPolls LordOfPolls added the Improvement Something that is already implemented but can be done better label Oct 15, 2022
@LordOfPolls LordOfPolls changed the title Rename button event refactor 💥: Rename button event to prevent overlap Oct 15, 2022
@LordOfPolls LordOfPolls merged commit d7a4b95 into 2.x Oct 16, 2022
@LordOfPolls LordOfPolls deleted the rename_button_event branch October 16, 2022 06:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silasary silasary silasary approved these changes

Assignees
No one assigned
Labels
Improvement Something that is already implemented but can be done better
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LordOfPolls @silasary